Track enable XslCompiledTransform Date/Time XSL test

Open
#115,455 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp

Research direction

Start with src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs around line 3168 and inspect the disabled date/time formatting test. Review issue #93189 for related culture handling, then run the relevant XslCompiledTransform tests under the POSIX/invariant culture. Done means the test is culture-agnostic, passes in that environment, and is re-enabled.

Written by the indexing model from the issue text.

Description

area-System.Xml disabled-test

The PR https://github.com/dotnet/runtime/pull/115415 added support for the Azure Linux image in CI. This image sets the default locale to POSIX, which .NET interprets as the Invariant culture. As a result, one of the XslCompiledTransform tests—specifically one that verifies date and time formatting in XSLT—fails because it doesn't handle culture-invariant scenarios correctly.

Relevant test line:

https://github.com/dotnet/runtime/blob/2c94e69db875a72511729de8855871a97d45050c/src/libraries/System.Private.Xml/tests/Xslt/XslCompiledTransformApi/XslCompiledTransform.cs#L3168

To unblock the PR, we’ve temporarily disabled the test. This issue is now tracking the work to re-enable it after updating the test to be culture-agnostic. To do so, the test logic updated accordingly. It will be good consider https://github.com/dotnet/runtime/issues/93189 when doing so.

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.