superpmi collection of PowerShell.Benchmarks.dll frequently fails with "No space left on device"

Open
#114,935 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp, powershell, python
Domain
ci-cd, performance

Research direction

Start with src/coreclr/scripts/superpmi_benchmarks.py around lines 219-267 and the PowerShell.Benchmarks.csproj real-world test. Inspect how much data the special core_root copy creates and how it affects the failing SuperPMI collection job. Done means determining whether the copy causes the disk exhaustion and identifying whether copied files can be deleted safely.

Written by the indexing model from the issue text.

Description

area-CodeGen-coreclr JIT-Infra

The runtime-coreclr superpmi-collection pipeline (https://dev.azure.com/dnceng/internal/_build?definitionId=977&_a=summary) frequently fails the SuperPMI collect realworld run linux x64 checked job in Partition5, which is the realworld test src/benchmarks/real-world/PowerShell.Benchmarks/PowerShell.Benchmarks.csproj.

The failure is something like:

[22:17:32] /datadisks/disk1/work/A6DB094A/w/C1920A4F/u/performance/tools/dotnet/x64/sdk/10.0.100-preview.4.25211.22/NuGet.targets(186,5): error : No space left on device : '/home/helixbot/.nuget/packages/system.directoryservices.accountmanagement' [/datadisks/disk1/work/A6DB094A/w/C1920A4F/u/performance/artifacts/PowerShell.Benchmarks-Job-LMRDDO-1/BenchmarkDotNet.Autogenerated.csproj]

I note that superpmi_benchmarks.py, which is used to run this test, has specific logic just for this test to create a copy of a large number of files to a new core_root directory:

https://github.com/dotnet/runtime/blob/31289efa35151a4e60dcd2e6471c51f620f78c28/src/coreclr/scripts/superpmi_benchmarks.py#L219-L267

Perhaps this is copying so much that whatever disk space we have on this machine is exhausted by, or at least impacted by, the copy? How much data is actually copied? If the copy is indeed a culprit, then can we delete the files after they are copied?

@dotnet/jit-contrib

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.