HttpClientFactory doesn't clean up after itself
Nobody has claimed this yet.
Assessment
This issue has not been assessed yet.
Description
Description
Recently I ran into an issue running tests using dotnet test that it would crash without any obvious reason.
Running my tests also showed memory would steadily increase over time whilst they were being run which indicated the presence of a memory leak.
Analysing the memory dump there were 1000s of timers holding on to objects that I would've expected to be disposed of all centered around ActiveHandlerTrackingEntry.
Reproduction Steps
Judging by the code, I'd say you could just get away with a for loop that creates a service collection, adds the http client factory, creates a service provider and then create a dozen or so http clients with it.
Expected behavior
When the service provider it's associated with is disposed of, all resources the http client factory is associated with should be disposed of and freed up, including any timers that it creates.
Actual behavior
Timers still hang around in the background, long after that instance of the http client factory is no longer in use. Which eventually consumes all available resources.
Regression?
No response
Known Workarounds
When running the tests ensuring the handler lifetime is set to infinite effectively bypasses the handler lifetime logic that creates the timers. Which stops the crashes that I was experiencing.
Configuration
Running .net 8.
MacOS and Linux, ARM64 and x64.
I don't think the configuration matters.
Other information
No response
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area-VM-meta-mono untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PowerShell/PSResourceGet#2056 ·