SPMI should diff unwind info

Open
#112,807 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
compilers, tooling

Research direction

Start in src/coreclr/tools/superpmi/superpmi/neardiffer.cpp at lines 1349-1381, where SPMI currently handles output differences. Read the surrounding diffing logic and identify how unwind info produced by the JIT should be included alongside the other outputs. Done means SPMI reports differences in unwind info; verify this through the existing SPMI comparison workflow.

Written by the indexing model from the issue text.

Description

area-CodeGen-coreclr

Currently SPMI does not diff unwind info produced by the JIT:
https://github.com/dotnet/runtime/blob/57ed25449ab954595130997679807a471ef85aef/src/coreclr/tools/superpmi/superpmi/neardiffer.cpp#L1349-L1381

Diffing this info could have prevented #112799, so it would probably be a good idea to diff it like the other outputs.

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.