`Process.MainWindowHandle` should prefer non-popup windows
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- operating-systems
Research direction
Start in src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Win32.cs at the linked window-selection code around lines 43-46. Reproduce a process with both normal and popup windows, then verify that MainWindowHandle prefers the non-popup window when both are visible and unowned.
Written by the indexing model from the issue text.
Description
Description
The Process.MainWindowHandle currently grabs the first window that 1) does not have owner 2) is visible:
Arguably if the process has multiple windows meeting this criteria with one of them having WS_POPUP, the popup is probably not the main window.
Reproduction Steps
Create a process with normal and a popup window. The repro relies on EnumWindow returning the popup first, but the order is not guaranteed.
Expected behavior
Popup windows are returned as main window even when non-popup windows exist.
Actual behavior
Prefer non-popup windows.
Regression?
No, same in .NET Framework.
Known Workarounds
Do not use Process.MainWindowHandle but do your own interop.
Configuration
.NET: not specific
OS: not specific (27793 x64)
Other information
No response
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area-VM-meta-mono untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PowerShell/PSResourceGet#2056 ·