Add LDAP tests to CI

Open
#112,108 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, docker
Domain
ci-cd, infrastructure, testing

Research direction

Start with src/libraries/Common/tests/System/DirectoryServices/LDAP.Configuration.xml and DirectoryServicesProtocolsTests.cs, then review the referenced docker commands and existing LDAP configurations. Determine which platform and TLS checkbox can be supported first, and verify that the selected LDAP tests run in CI with the required server setup and certificate validation.

Written by the indexing model from the issue text.

Description

area-System.DirectoryServices test-enhancement

The LDAP tests do not run in CI since there is infrastructure required to set up an LDAP server as explained in the various "docker run" commands and Active Directory section in https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/System/DirectoryServices/LDAP.Configuration.xml.

This means every release we need to manually verify these tests.

Ideally, we add the following support:

  • Support the OpenSsl (Linux and OsX) tests running by using the docker commands above and specify the environment variable so that the check for DirectoryServicesProtocolsTests.LdapConfigurationExists succeeds.
  • Extend or add a new configuration based on "SLAPD OPENLDAP SERVER TLS" to enable the TLS handshake to test client and server certificate validation. See also https://github.com/dotnet/runtime/issues/60972 where VerifyServerCertificate() doesn't work on Linux thus the need for an example + test. Currently, handshake is disabled in the XML instructions via "LDAP_TLS_VERIFY_CLIENT=never". High level steps include:
    • Use "LDAP_TLS_VERIFY_CLIENT=demand"
    • Add support for adding the properly hashed client certificate to a directory and setting the TrustedCertificatesDirectory property to that directory.
    • Have the client trust the server certificate.
    • Call StartTransportLayerSecurity(null).
  • Support the OpenSsl (ActiveDirectory - Windows) tests. This is more difficult than the Linux and may not be feasible.
Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.