Consider enabling PortBlocker tests on Wasi

Open
#112,039 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, wasm
Domain
networking, testing-qa

Research direction

Start in src/libraries/Common/tests/System/Net/Sockets/SocketTestExtensions.cs around lines 205-209, where PortBlocker tests are opted out for Wasi. Check the Wasi socket-test setup and determine the correct wasi-libc import name to enable those cases, then run the affected socket tests to confirm they pass on Wasi.

Written by the indexing model from the issue text.

Description

arch-wasm area-System.Net.Sockets os-wasi

#106977 introduced support for Wasi sockets, but opted-out from test cases using PortBlocker.

@pavelsavara could this be fixed by replacing libc with the right name to import wasi-libc here?

https://github.com/dotnet/runtime/blob/572533b433aa1b0b5a498cec2d310b939acd3a93/src/libraries/Common/tests/System/Net/Sockets/SocketTestExtensions.cs#L205-L209

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.