[API Proposal]: Additional X.509 collection content types in X509CertificateLoader

Open
#111,547 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
cryptography, security

Research direction

Start by reading the X509CertificateLoader API proposal and comparing it with the obsolete X509Certificate2Collection.Import behavior described in the issue. Define the additional collection content-type entry points, including PKCS#7, and verify that the resulting APIs load the corresponding certificate collections.

Written by the indexing model from the issue text.

Description

api-suggestion area-System.Security
Background and motivation

The new X509CertificateLoader class is a regression compared to the now obsolete X509Certificate2Collection.Import in that it only supports PKCS#12 collections, whereas X509Certificate2Collection.Import supports not only PKCS#12 but also PKCS#7, Authenticode, etc. This means that users depend on an obsolete API just to load those X.509 content types.

API Proposal
namespace System.Security.Cryptography.X509Certificates;

public static class X509CertificateLoader
{
    public static X509Certificate2Collection LoadPkcs7Collection(byte[] data);
    public static X509Certificate2Collection LoadPkcs7Collection(ReadOnlySpan<byte> data);

   // Repeat for other content types.
}
API Usage
byte[] pkcs7Bytes = []; // This will be replaced by actual bytes from a p7b file.
X509Certificate2Collection pkcs7Collection = X509CertificateLoader.LoadPkcs7Collection(pkcs7Bytes);

ReadOnlySpan<byte> pkcs7Bytes = []; // This will be replaced by actual bytes from a p7b file.
X509Certificate2Collection pkcs7Collection = X509CertificateLoader.LoadPkcs7Collection(pkcs7Bytes);
Alternative Designs

No response

Risks

No response

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.