Missing loadAllSatelliteResources Property in MonoConfig Class in dotnet.d.ts

Open
#111,455 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript

Research direction

Open dotnet.d.ts and locate the MonoConfig definition used by withConfig. Add the missing optional property definition, then verify that the provided configuration example no longer produces a TypeScript error.

Written by the indexing model from the issue text.

Description

arch-wasm area-System.Runtime.InteropServices.JavaScript os-browser

The loadAllSatelliteResources property is missing from the config class definition in dotnet.d.ts. This causes a TypeScript error when attempting to configure the dotnet object with this property in the following code:

dotnet
    .withVirtualWorkingDirectory(runArgs.workingDirectory)
    .withEnvironmentVariables(runArgs.environmentVariables)
    .withDiagnosticTracing(runArgs.diagnosticTracing)
    .withExitOnUnhandledError()
    .withExitCodeLogging()
    .withElementOnExit()
    .withInteropCleanupOnExit()
    .withDumpThreadsOnNonZeroExit()
    .withConfig({
        loadAllSatelliteResources: true,
        jsThreadBlockingMode: "ThrowWhenBlockingWait",
    });

Expected Behavior
The config class in dotnet.d.ts should include a definition for the loadAllSatelliteResources property to allow seamless configuration without TypeScript errors.

Actual Behavior
The TypeScript compiler throws an error because loadAllSatelliteResources is not recognized as a valid property of the config object in dotnet.d.ts.

Steps to Reproduce

  • Use the dotnet object and attempt to configure it as shown in the example above.
  • Include the loadAllSatelliteResources property in the withConfig method.
  • Observe the TypeScript error related to the missing property in dotnet.d.ts.

Suggested Solution
Add the loadAllSatelliteResources property to the config class definition in dotnet.d.ts. For example:

type MonoConfig {
    loadAllSatelliteResources?: boolean;
    jsThreadBlockingMode?: string;
    // other existing properties
}

Environment

  • Language: TypeScript

  • Platform: .NET Runtime

Let me know if you need additional details!

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR merge metrics
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.