Avoid hardcoded NetCoreAppToolCurrent* properties
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- build-system
Research direction
Start by reading the repository's Directory.Build.props and global.json, then review how NETCoreAppMaximumVersion becomes available during SDK evaluation. Compare the current NetCoreAppToolCurrent* properties with SDK issue 29949 and define a build that works with newer SDKs and the VMR without requiring a hardcoded shared-framework TFM.
Written by the indexing model from the issue text.
Description
The NetCoreAppToolCurrentVersion is hardcoded to 9.0 which causes issues when building with a newer SDK that doesn't have a shared framework for that given TFM (i.e. inside the VMR). As we already enforce a minimum required SDK version in global.json, it would be better to automatically calculate the NetCoreAppToolCurrentVersion value based on the SDK being used.
The SDK exposes the NETCoreAppMaximumVersion property but unfortunately a little bit too late, after the repo's Directory.Build.props file is imported.
We could avoid the NetCoreAppToolCurrent* properties altogether when the SDK implements https://github.com/dotnet/sdk/issues/29949. That would the ideal path forward.
- Dominant language
- C#
- Stars
- 18.3k
- Forks
- 5.6k
- PR merge metrics
- PR metrics pending
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/runtime
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
area-System.Reflection blocking-clean-ci-optional Known Build Error os-mac-os-x untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
area-CodeGen-coreclr untriaged
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
agentic-workflows untriaged
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area-VM-meta-mono untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
Create parent directories only after the containment check in InstallHelper.TryExtractToDirectory Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PowerShell/PSResourceGet#2056 ·