ILLink: RUC on derived virtual should not warn if base class has RUC

Open
#108,090 1 comment 1 reaction 2 assignees View on GitHub

@sbomer is already working on this.

Since Jan 21, 2026.

Assessment

This issue has not been assessed yet.

Description

area-Tools-ILLink

Consider a type Base that has RequiresUnreferencedCode:

[RequiresUnreferencedCode("Base")]
class Base {
    public Base() {}

    public virtual void Instance() {}
}

It should be possible to annotate a derived class, without necessarily marking all static methods in the derived class as RUC:

class Derived : Base {
    [RequiresUnreferencedCode("Base")]
    public Derived() {}

    [RequiresUnreferencedCode("Instance")] // warning: annotation mismatch
    public override void Instance() => Helper.RUC();

    public static void Static() {}
}

[RequiresUnreferencedCode("Helper")]
class Helper {
    public static void RUC() {}
}

Today ILLink warns about mismatching annotations on Derived.Instance and Base.Instance:

Trim analysis warning IL2046: Derived.Instance(): Member 'Derived.Instance()' with 'RequiresUnreferencedCodeAttribute' overrides base member 'Base.Instance()' without 'RequiresUnreferencedCodeAttribute'. 'RequiresUnreferencedCodeAttribute' annotations must match across all interface implementations or overrides.

This should not happen. The analyzer and ILC don't produce the same warning.

(note that this scenario also produces a separate warning about Derived deriving from Base, which should also be removed, see https://github.com/dotnet/runtime/issues/107660.)

Dominant language
C#
Stars
18.3k
Forks
5.6k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/runtime

All issues in dotnet/runtime

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.