PERF: Omit SELECT @@ROWCOUNT; when we are executing just a single statement

Open
#7,037 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp, sql

Research direction

Start by tracing the single-statement execution path that currently uses ExecuteReader and issues SELECT @@ROWCOUNT. Determine whether ExecuteCommand exposes rowsAffected for this case; done means the extra SELECT is omitted without changing affected-row results.

Written by the indexing model from the issue text.

Description

area-perf area-save-changes

Should be able to use ExecuteCommand and check rowsAffected instead of ExecuteReader.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.