Support modifying the value of primary or alternate key properties

Open
#4,073 13 comments 27 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
databases

Research direction

Start at src/EntityFramework.Core/ChangeTracking/Internal/InternalEntityEntry.cs around line 231 and inspect how IsKey is used when modifying properties. Determine the intended behavior for primary versus alternate key properties, then verify that the requested modification behavior is covered by the project's existing change-tracking tests.

Written by the indexing model from the issue text.

Description

area-change-tracking

In the following location, an exception is raised when attempting to make modifications to a property that belongs to either a primary or alternate key (using the IsKey extension method):

https://github.com/aspnet/EntityFramework/blob/7.0.0-rc1/src/EntityFramework.Core/ChangeTracking/Internal/InternalEntityEntry.cs#L231

I have to ask: why restrict modifications on alternate keys, and why not use IsPrimaryKey here instead?

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.