Remove / Obsolete usages of ValueBuffer

Open
#26,544 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
database

Research direction

Start by reviewing the remaining checklist items, especially JSON key values in RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs and MaterializationContext. Search for other ValueBuffer usages and compare them with the suggested object[], EntityEntry, or generic alternatives. Done means the remaining obsolete usages are replaced and the linked issue work is addressed.

Written by the indexing model from the issue text.

Description

area-global area-perf
  • IIdentityMap.Contains
  • IPrincipalKeyValueFactory<>.CreateFromBuffer
  • IReadOnlyModificationCommand.PropagateResults
  • #31117
  • JSON key values, see RelationalShapedQueryCompilingExpressionVisitor.ShaperProcessingExpressionVisitor.cs
  • MaterializationContext
  • https://github.com/dotnet/efcore/issues/21335
  • Look for more places where it can be replaced with object[], EntityEntry or a generic type that avoids boxing
Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.