SqliteCommand.GetStatements allocates List<T> enumerator per every prepared query

Open
#26,494 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sqlite
Domain
database, performance

Research direction

Locate SqliteCommand.GetStatements and the _preparedStatements and PrepareAndEnumerateStatements members. Read how prepared queries are currently traversed, then check the relevant tests or allocation measurements available in the repository. Done means the iteration follows the issue's proposed structure without allocating a List enumerator for each prepared query.

Written by the indexing model from the issue text.

Description

area-adonet-sqlite area-perf customer-reported

One way this can be mitigated is by:

  1. Moving most of the GetStatements logic into another method (which only operates on a single statement).
  2. Changing GetStatements so it iterates over _preparedStatements list with for, and foreach over PrepareAndEnumerateStatements.
Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.