Improve provider scaffolding by providing a specification base class

Open
#25,996 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
databases, testing-qa

Research direction

Start by reading the existing scaffolding tests and the migration tests, noting that the former use provider-specific raw SQL DDL while the latter construct an EF model and use migrations. The work is done when scaffolding specification tests can use that model-and-migrations approach without each provider manually maintaining schema setup.

Written by the indexing model from the issue text.

Description

area-scaffolding area-test needs-design

Our scaffolding tests currently use raw SQL DDL to create the schema to be created; since that SQL is database-specific, we have no specification tests for scaffolding, and each provider must manually keep tests up to date, etc.

We could have the tests construct an EF model, and use migrations to create the database which we would then scaffold.

Note: our migration tests already do this, but in reverse (scaffolding is used to assert that the migration did the expected thing).

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.