ForeignKeyPropertyDiscoveryConvention doesn't trigger when a shadow property is added that matches the property created implicitly

Open
#25,830 1 comment 0 reactions 1 assignee View on GitHub

@AndriySvyryd is already working on this.

Since Sep 17, 2023.

Assessment

This issue has not been assessed yet.

Description

area-conventions area-model-building

This causes the principal side to remain ambiguous when it shouldn't be.

See https://github.com/dotnet/efcore/blob/b7f88600e6206f9dea39c26e83d6c43defbe08a2/test/EFCore.Tests/ModelBuilding/TestModel.cs#L371

This might be easier to fix after #15898 is implemented

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.