Avoid pushdown when applying OrderBy over Distinct

Open
#25,698 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
databases

Research direction

Use the provided Distinct().OrderBy(...) query as the reproduction and compare its generated SQL with the two examples. Trace the EF Core query translation path for Distinct followed by OrderBy; done means the query avoids the derived-table pushdown and produces the simpler SQL shown in the issue.

Written by the indexing model from the issue text.

Description

area-query customer-reported

This query:

_ = await ctx.Blogs.Distinct().OrderBy(a => a.Id).ToListAsync();

Currently produces:

SELECT [t].[Id], [t].[Name]
FROM (
    SELECT DISTINCT [b].[Id], [b].[Name]
    FROM [Blogs] AS [b]
) AS [t]
ORDER BY [t].[Id]

Whereas it could produce:

SELECT DISTINCT [b].[Id], [b].[Name]
FROM [Blogs] AS [b]
ORDER BY [b].[Id]
Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.