SQLite: Translate more DateOnly and TimeOnly members

Open
#25,103 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sqlite
Domain
databases

Research direction

Start by reviewing the existing TimeOnly translations from issue #18844 and the discussion linked in issue #24506. Work through the listed DateOnly and TimeOnly members, with particular attention to precision and day-wrapping; the issue is complete when the intended SQLite translations are defined and implemented for those cases.

Written by the indexing model from the issue text.

Description

area-query area-sqlite

In addition to adding the corresponding TimeOnly translations listed in issue #18844, here are some additional members we could translate:

.NET SQL
DateOnly.FromDateTime(dateTime) date($dateTime)
date.ToDateTime(time) $date || ' ' || $time
TimeOnly.FromDateTime(dateTime) time($dateTime)
TimeOnly.FromTimeSpan(timeSpan) $timeSpan
time.Add(timeSpan) time(ef_days($time) + ef_days($timeSpan))
time.IsBetween(start, end) ef_days($time) BETWEEN ef_days($start) AND ef_days($end)
time.ToTimeSpan() $time

❗ Important: These translations are currently over-simplified. We need to think more about precision and day-wrapping.

See also https://github.com/dotnet/efcore/issues/24506#issuecomment-808335218

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.