Look into parameter placeholder generation in RawSqlCommandBuilder
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Read src/EFCore.Relational/Storage/Internal/RawSqlCommandBuilder.cs, focusing on GenerateParameterNamePlaceholder, both GenerateParameterName overloads, and the nameless DbParameter path. Compare them with the other command-generation places mentioned in the issue; done means the placeholder and parameter-name behavior is consistent and provider requirements are accounted for.
Written by the indexing model from the issue text.
Description
In RawSqlCommandBuilder, GenerateParameterNamePlaceholder doesn't seem to be used (only GenerateParameterName is used). Note that if a nameless DbParameter is provided, GenerateParameterName is called twice.
This likely isn't a problem at the moment because both methods do the same thing by default (prepend a '@' if it's missing), and current providers don't need anything more - but it's probably not correct. Also compare this against what we're doing in other command-generation places.
Raised by @deokershesh in #22441
Also, seems that GenerateParameterName(string) prepends @ only if the given name doesn't already have it, but GenerateParameterName(StringBuilder,string) always prepends... We should go over this.
- Dominant language
- C#
- Stars
- 14.8k
- Forks
- 3.4k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 134
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/efcore
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
customer-reported
Difficulty 5/5 Over a week Newbie friendliness 38/100
-
area-cosmos area-vector-search
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-cosmos
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-tools needs-design
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100