ToQueryString on a split query only shows the first query

Open
#22,080 15 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sql
Domain
databases

Research direction

Start with the supplied C# reproduction using Include, ThenInclude, AsSplitQuery, and ToQueryString, then compare its output with the three SQL statements logged by queryable.ToList(). Trace the ToQueryString path for split queries. Done means the output represents all three generated queries, matching the logged SQL.

Written by the indexing model from the issue text.

Description

area-query needs-design

For the query below, ToQueryString returns

SELECT [c].[Id]
FROM [Chunky] AS [c]
ORDER BY [c].[Id]

I would expect it to show all three queries that eventually get logged:

SELECT [c].[Id]
FROM [Chunky] AS [c]
ORDER BY [c].[Id]

SELECT [c0].[Id], [c0].[ChunkyId], [c].[Id]
FROM [Chunky] AS [c]
INNER JOIN [Cherry] AS [c0] ON [c].[Id] = [c0].[ChunkyId]
ORDER BY [c].[Id], [c0].[Id]

SELECT [m].[Id], [m].[CherryId], [c].[Id], [c0].[Id]
FROM [Chunky] AS [c]
INNER JOIN [Cherry] AS [c0] ON [c].[Id] = [c0].[ChunkyId]
INNER JOIN [Monkey] AS [m] ON [c0].[Id] = [m].[CherryId]
ORDER BY [c].[Id], [c0].[Id]

Code:

public class SomeDbContext : DbContext
{
    private static readonly ILoggerFactory
        Logger = LoggerFactory.Create(x => x.AddConsole());//.SetMinimumLevel(LogLevel.Debug));

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder.Entity<Chunky>();
    }
    
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseLoggerFactory(Logger)
            .EnableSensitiveDataLogging()
            .UseSqlServer(Your.SqlServerConnectionString);
}

public static class Program
{
    public static void Main()
    {
        using (var context = new SomeDbContext())
        {
            context.Database.EnsureDeleted();
            context.Database.EnsureCreated();

            context.Add(new Chunky
            {
                Cherries = new List<Cherry>
                {
                    new Cherry
                    {
                        Monkeys = new List<Monkey> {new Monkey()}
                    }
                }
            });

            context.SaveChanges();
        }

        using (var context = new SomeDbContext())
        {
            var queryable = context.Set<Chunky>().Include(e => e.Cherries).ThenInclude(e => e.Monkeys).AsSplitQuery();
            Console.WriteLine(queryable.ToQueryString());
            queryable.ToList();
        }
    }
}

public class Chunky
{
    public int Id { get; set; }
    public ICollection<Cherry> Cherries { get; set; }
}

public class Cherry
{
    public int Id { get; set; }
    public ICollection<Monkey> Monkeys { get; set; }
}

public class Monkey
{
    public int Id { get; set; }
}
Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.