Create DiagnosticSuppressor for CS8602 in Linq expressions and Includes
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by examining EF Core's IQueryable LINQ methods and Include/ThenInclude entry points, using the issue's nullable-property examples as the expected scenarios. Determine how a DiagnosticSuppressor can target CS8602 only for database-translated expressions, then verify that the warning is suppressed in those cases without being suppressed elsewhere.
Written by the indexing model from the issue text.
Description
Currently CS8602 (Dereference of possibly null reference) is triggered for nullable properties in linq expressions, even though no NRE possible when query is executed on DB side.
Example 1 (Linq):
class User
{
public string FirstName {get;set;}
public string? MiddleName {get;set;}
public string LastName {get;set;}
}
...
string searchTerm = "...";
await dbContext.Users
.Where(u => u => u.FirstName.Contains(searchTerm)
|| u.MiddleName.Contains(searchTerm) <---------- CS8602 is reported, as 'MiddleName' is nullable
|| u.LastName.Contains(searchTerm))
.ToListAsync();
Example 2 (Includes):
class SomeModel
{
public class NavigationModel Navigation? {get;set;}
}
class NavigationModel
{
public class AnotherNavigationModel DeeperNavigation {get;set;}
}
dbContext.Models
.Include(m => m.Navigation)
.ThenInclude(n => n.DeeperNavigation) <----- CS8602 is reported, as 'n' is nullable
Suggestion:
Create DiagnosticSuppressor for CS8602 for IQueryable expressions in Linq methods and for Include/ThenInclude methods.
- Dominant language
- C#
- Stars
- 14.8k
- Forks
- 3.4k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 134
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/efcore
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
customer-reported
Difficulty 5/5 Over a week Newbie friendliness 38/100
-
area-cosmos area-vector-search
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-cosmos
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-tools needs-design
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100