Query: Improve SQL readability

Open
#21,475 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sql
Domain
databases

Research direction

Start by locating the SQL generation path that formats projection CASE expressions and inspect how multiple WHEN clauses and complex THEN or ELSE values are represented. Add coverage for the shown formatting and the stated multi-clause and complex-value cases, then verify the generated SQL is readable and valid.

Written by the indexing model from the issue text.

Description

area-query customer-reported

Currently we generate SQL projection like this for case blocks

SELECT [a].[Species], [a].[CountryId], [a].[Name], [b].[EagleId], [b].[IsFlightless], [e].[Group], [k].[FoundOn], CASE
    WHEN [e].[Species] IS NOT NULL THEN CAST(1 AS bit)
    ELSE CAST(0 AS bit)
END AS [IsEagle], CASE
    WHEN [k].[Species] IS NOT NULL THEN CAST(1 AS bit)
    ELSE CAST(0 AS bit)
END AS [IsKiwi]

To make it more readable we can generate

SELECT [a].[Species], [a].[CountryId], [a].[Name], [b].[EagleId], [b].[IsFlightless], [e].[Group], [k].[FoundOn],
CASE WHEN [e].[Species] IS NOT NULL THEN CAST(1 AS bit) ELSE CAST(0 AS bit) END AS [IsEagle],
CASE WHEN [k].[Species] IS NOT NULL THEN CAST(1 AS bit) ELSE CAST(0 AS bit) END AS [IsKiwi]

Things to consider, SQL case may contain more than 1 CaseWhenClause.
The values of THEN and ELSE can be more complex.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.