Compiled query APIs has generically-typed parameters, but delegates to param object[]

Open
#21,126 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
backend, databases, performance

Research direction

Start with the generic APIs in src/EFCore/EF.CompileAsyncQuery.cs and follow their calls into src/EFCore/Query/Internal/CompiledQueryBase.cs. Trace how execution reaches QueryContext and identify the existing per-execution params object[] allocation and boxing. Done means executions avoid that array allocation while preserving the compiled query API behavior.

Written by the indexing model from the issue text.

Description

area-perf area-query

Our compiled query API surface is nice and generic, accepting up to 16 generic parameters (e.g. CompileAsyncQuery). However, these generic methods seem to call into non-generic methods which accept params object[], so that an array parameter is allocated and all parameter values are boxed.

Actually flowing generic parameters all the way into QueryContext (and from there into a generic DbParameter, if we ever get one), is likely to require quite a bit of work. In the meantime we can at least avoid the array allocation on every execution.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.