Consider an object overload for SqlServerDbFunctionsExtensions

Open
#20,962 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sql
Domain
database

Research direction

Start by locating SqlServerDbFunctionsExtensions and its existing DataLength overloads. Inspect how value-converted model types are translated for SQL Server, then add coverage showing the object overload works with those types. Done means the overload is supported without regressing the existing typed overloads.

Written by the indexing model from the issue text.

Description

area-query needs-design

We currently have the following overloads:

        public static int? DataLength(this DbFunctions _, string arg)
        public static int? DataLength(this DbFunctions _, bool? arg)
        public static int? DataLength(this DbFunctions _, double? arg)
        public static int? DataLength(this DbFunctions _, decimal? arg)
        public static int? DataLength(this DbFunctions _, DateTime? arg)
        public static int? DataLength(this DbFunctions _, TimeSpan? arg)
        public static int? DataLength(this DbFunctions _, DateTimeOffset? arg)
        public static int? DataLength(this DbFunctions _, byte[] arg)
        public static int? DataLength(this DbFunctions _, Guid? arg)

The main use case for an object overload is when a value converter is being used in the model such that the type in the application is not one of the types above, but the type in the database is still something that DATALENGTH can be called with.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.