Benchmarks: shows results per single operation instead of batching operations

Open
#19,875 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
28/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
performance, testing

Research direction

Start with the benchmark implementations, including FuncletizationTests, and review how BenchmarkDotNet reports batched operations. Use OperationsPerInvoke so results are shown per operation, then address the required database cleanup and verify the benchmark output.

Written by the indexing model from the issue text.

Description

area-benchmarks area-perf blocked

Many of our benchmarks (e.g. FuncletizationTests) perform a look inside the method to avoid having the method call overhead skew the results. This is good practice, but results are reported for the batch instead of per-operation; BenchmarkDotNet allows a benchmark to expose how many operations are invoked in the function for display purposes (OperationsPerInvoke).

Requires a database cleanup as well at the same time, can do this on my next visit to Redmond.

/cc @sebastienros

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.