Add support for provider convention types

Open
#19,806 0 comments 0 reactions 1 assignee View on GitHub

@AndriySvyryd is already working on this.

Since Feb 5, 2020.

Assessment

This issue has not been assessed yet.

Description

area-conventions area-model-building providers-beware
  • Also add a hook to add provider-specific convention types. Something like ProviderConventionDispatcher that also determines which annotations should be ignored
    • Add support for the provider conventions to the API on ModelConfigurationBuilder
    • Add a convention type for merging annotations from derived to base objects when the base type changes
  • Add conventions that react to property facet overrides. Most relational conventions should have a nullable StoreObjectIdentifier parameter #19811
  • Change RelationalDbFunctionAttributeConvention, TableNameFromDbSetConvention, RelationalValueGenerationConvention, SqlServerIndexConvention and other annotation conventions to use new convention types.
  • Don't return core annotations from GetAnnotations

Related to https://github.com/dotnet/efcore/issues/214, https://github.com/dotnet/efcore/issues/14103, https://github.com/dotnet/efcore/issues/15675

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.