Query: optimize arithmetic operation on constants

Open
#18,819 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, sql
Domain
databases

Research direction

Start by tracing the SqlServer Substring translation described in the issue and locate where the generated SQL expression is assembled. Verify the change by checking that an expression such as 1 + 1 is emitted as 2 in the resulting SQL; no file or test is named in the issue.

Written by the indexing model from the issue text.

Description

area-query

Currently when we translate Substring on SqlServer into something like this:

SUBSTRING([c].[ContactName], 1 + 1, 3)

we should simplify 1+1 into 2

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.