Allow translating non-constant NewExpression in translators and plugins
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- csharp
- Domain
- backend-api-design, database
Research direction
Start with the NodaTime expression shown in the issue and trace how NewExpression nodes with non-evaluatable constructor arguments reach translators and plugins. Compare this with the SQL translating visitor path mentioned for DateTime. Done means such constructors can be translated through a translator and the capability is exposed to plugins without relying on constant evaluation.
Written by the indexing model from the issue text.
Description
We currently can't translate the following NodaTime expression:
var d = ctx.NodaTimeTypes.Single(t => t.LocalDate < new LocalDate(t.LocalDate.Year, 4, 21));
... since the constructor contains a non-evaluatable parameter. Ideally it should be possible to translate via a translator (like method or member), and exposed to plugins as well.
Low priority, at the moment am only aware of NodaTime types - but there may be others. Raised in https://github.com/npgsql/efcore.pg/issues/1020.
Note that for DateTime this can be done in the SQL translating visitor, as it isn't a plugin.
- Dominant language
- C#
- Stars
- 14.8k
- Forks
- 3.4k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 134
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/efcore
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
customer-reported
Difficulty 5/5 Over a week Newbie friendliness 38/100
-
area-cosmos area-vector-search
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-cosmos
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-tools needs-design
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100