Only avoid caching of RelationalCommand when visitor says so

Open
#18,034 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
20/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
databases

Research direction

Start by reading issues #15892 and #16375 to understand the current ParameterBased EV behavior and its false positives. Determine whether RelationalCommand caching should depend on the visitor's result, and document or implement a decided approach with coverage for the affected caching behavior.

Written by the indexing model from the issue text.

Description

area-query

While implementing #15892, currently it takes approach that if ParameterBased EV changes SelectExpression, we cannot cache it. It has false positives since we have #16375. i.e. constants are also process there so we could potentially cache it. If we fix #16375 then this has lower value so filing issue to decide what should we do.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.