Execute parameter-based optimizations only if the query requires it

Open
#17,597 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
database

Research direction

Start by tracing ParameterValueBasedSelectExpressionOptimizer and the named expression visitors through query compilation and execution. The work is complete when compilation identifies whether each visitor is needed and execution skips unnecessary parameter-based optimizations, including for queries without InExpression, while preserving required behavior.

Written by the indexing model from the issue text.

Description

area-perf area-query

ParameterValueBasedSelectExpressionOptimizer runs InExpressionValuesExpandingExpressionVisitor and FromSqlParameterApplyingExpressionVisitor at query execution (not compilation). We can detect during compilation if these visitors are actually necessary and flow that information to the execution phase.

For example, for queries which don't contain InExpression we wouldn't need to run InExpressionValuesExpandingExpressionVisitor.

See also #16375 which is related.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.