Extension point needed after applying migrations programmatically

Open
#17,568 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, postgresql
Domain
backend, database

Research direction

Start by reading the public RelationalDatabaseCreator path and the internal Migrator path used by context.Database.Migrate(). Compare how EFCore.PG handles database creation and programmatic migrations, then determine the appropriate extension point for notifying ADO about PostgreSQL type changes. Done means the required hook is defined and its behavior is covered for programmatic migration use.

Written by the indexing model from the issue text.

Description

area-aspire area-migrations needs-design

Original issue: https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues/292

tl;dr PostgreSQL has extensions, which can be added via the regular migration process. However, since extensions can add database types, the ADO layer must be instructed to reload types.

EFCore.PG does this if the migration is applied when first creating a database, since RelationalDatabaseCreator is public. However, for users applying migrations programmatically (context.Database.Migrate()) this would currently require extending Migrator, which is an internal type.

This is a non-critical issue - users can work around it by triggering type reloading themselves. Npgsql can also extend Migrator for now even though it's internal.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.