Make CLR members lookup for Metadata consistent

Open
#15,583 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
databases

Research direction

Start with TypeBase.GetRuntimeFields() and TypeBase.GetRuntimeProperties(), then trace GetMembersInHierarchy() and the base entity type used for metadata lookup. Confirm that private members in base types are found without calling the runtime member methods, while preserving the intended lookup performance; the issue does not name a test file.

Written by the indexing model from the issue text.

Description

area-model-building

Don't call GetRuntimeFields() / GetRuntimeProperties(), instead use GetMembersInHierarchy() to be able to find private members in base types.

Fix TypeBase.GetRuntimeFields() and TypeBase.GetRuntimeProperties() and leverage the base entity type for perf.

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.