Consider translating `System.Math.Round(double, MidpointRounding)`

Open
#15,427 9 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp, sql
Domain
databases

Research direction

Start by comparing System.Math.Round(0.5) with the MSSQL ROUND and Firebird ROUND behavior described in the issue. Find the EF Core query-translation entry point for this method and determine the expected provider behavior; done means the requested rounding behavior is translated consistently and covered by appropriate verification.

Written by the indexing model from the issue text.

Description

area-query customer-reported

Hello.

System.Math.Round(0.5) returns 0

MSSQL ROUND(0.5) returns 1

You know about these difference in implementation of ROUND function?

PS. Firebird ROUND(0.5) returns 1 also

Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.