Consider Migrations behavior when store-generated GUID doesn't have DefaultValueSql set

Open
#14,532 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
database

Research direction

Start by reading issue #14518 and tracing how generated values without a value generator are handled by the update pipeline and Migrations. Compare the proposed warning, model-validation warning, and convention-based default approaches, including SQL Server's newsequentialid(). Done requires a decided behavior for existing databases and migration-created databases.

Written by the indexing model from the issue text.

Description

area-migrations area-model-building

See issue #14518. In this case, the property should be treated as store-generated by the update pipeline because:

  • It is configured to have a generated value
  • It has no associated value generator

This makes sense when the database already exists, but if the database is being created by migrations then we don't know what default constraint makes sense. Options discussed were:

  • Warn in Migrations (may need us to build a mechanism to do so)
  • Warn in model validation (warning will be shown even when database exists and is fine)
  • Set a sensible default constraint by convention (for example, newsequentialid() for GUIDs on SQL Server; less clear what makes sense for other types and other providers.)
Dominant language
C#
Stars
14.8k
Forks
3.4k
Avg merge
2d 5h
Merged PRs (30d)
134

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/efcore

All issues in dotnet/efcore

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.