Query: Allow non static methods in top level projection
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with the attached ReproduceEFCoreMemoryLeakNonStaticHelperMethods.zip project and run its snapshot/GC reproduction. Inspect Repository.GetInt(), the non-static HashCode method, and the contrasting RepositoryStatic path to understand the query projection behavior. Done means the reproduced disposed contexts are no longer retained after collection.
Written by the indexing model from the issue text.
Description
Under a specific condition, disposed context's are not being released with a GC. In production it is rapidly increasing memory usage.
Memory Analysis done with Jetbrains dotMemory.
Attached working project:
ReproduceEFCoreMemoryLeakNonStaticHelperMethods.zip
Sample from attached code:
Console.WriteLine("Take 1st snapshot!");
Console.ReadLine();
for(var i=0; i<10; i++)
using (var context = new TestContextSql())
{
var repo = new Repository(context); // <--- The non static helper will leave 10 instances TestContextSql in memory.
//var repo = new RepositoryStatic(context); // <--- The static helper will leave 1 instances TestContextSql in memory.
var query = repo.GetInt();
var list = query.ToList();
}
Console.WriteLine("Force GC");
GC.Collect();
Console.WriteLine("Take 2nd snapshot");
Console.ReadLine();
public IQueryable<int> GetInt()
{
return _context.TestEntities.Select(t => HashCode(t.DateRange1));
}
private int HashCode(string dateRange1)
{
return dateRange1.GetHashCode();
}
Occurs in:
EF Core 2.0.1
EF Core 2.1.1
- Dominant language
- C#
- Stars
- 14.8k
- Forks
- 3.4k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 134
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/efcore
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
customer-reported
Difficulty 5/5 Over a week Newbie friendliness 38/100
-
area-cosmos area-vector-search
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-cosmos
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
area-tools needs-design
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·
-
area/docs-content Bug pulumi/docs
Difficulty 1/5 1-3 hours Newbie friendliness 94/100
-
agentic-workflows untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 76/100