dimforge / dimforge/nalgebra

#[inline] on generic functions

Open
#312 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.8k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

Should `#[inline]` tags be present on generic functions? As far as I know, they don't actually help with inlining, since generic functions are instantiated for each type during monomorphization. However, they may actually incur a cost on compile times, which are quite long for nalgebra.

The above statements should be tested with benchmarks, before doing anything about this, of course. Is there an argument for why the annotations should stay or are they just present out of habit?

EDIT: typo

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.