dimforge / dimforge/nalgebra

Rotation3::from_matrix hangs when a matrix with left handed coordinate system is passed in

Open
#1,583 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.8k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

When passing in a matrix with a left handed coordinate system (negative determinant) the `Rotation3::from_matrix` deadlocks. Running this code never exits:

```
let rot = Rotation3::from_matrix(&Matrix3::new(
0.7071067811865477,
0.7071067811865475,
0.0,
-0.7071067811865475,
0.7071067811865475,
0.0,
0.0,
0.0,
-1.0,
));
```

It would be nice if the code can at least panic / raise an error in another way / not deadlock when the algorithm won't converge.

Tested on nalgebra 0.34.1

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.