dimforge / dimforge/nalgebra

Do not explicitly set rkyv pointer size

Open
#1,449 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.8k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

Cargo.toml currently sets `rkyv-serialize-no-std = ["rkyv/size_32"]` which prevents using `rkyv` with any other pointer size. It is best practice for libraries to not set the pointer size and allow binaries to choose the pointer size themselves. For myself, I patched this to `rkyv-serialize-no-std = ["rkyv"]`, although I imagine that testing might require it to still be set in some circumstances?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.