Similarity scaling private
Open
- Dominant language
- Rust
- Stars
- 4.8k
- Forks
- 565
- PR merge metrics
- No merged PRs in 30d
Description
Why is the scaling part of a Similarity not public? I don't see any good reason for that.
https://github.com/dimforge/nalgebra/blob/a91e3b0d8917f3fab8486d45857119af1fd37ecd/src/geometry/similarity.rs#L53-L57
The `set_scaling` method just asserts that it is not zero, but if that has to be enforced even when allowing public access to the scaling field, then it might be better to do this via some type that can only be constructed with non-zero values.
https://github.com/dimforge/nalgebra/blob/a91e3b0d8917f3fab8486d45857119af1fd37ecd/src/geometry/similarity.rs#L89-L96
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.