dimforge / dimforge/nalgebra

Unnecessary `Copy` restrictions in conversions?

Open
#1,091 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.8k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

Some of the conversions in `src/base/conversion.rs` between `Matrix` and `&[T]` using `From` require `T: Scalar + Copy`. The `Scalar` trait bound seems sensible, but the `Copy` requirement is not imposed anywhere else. Is there a reason that `T` must be `Copy` or can this bound be safely removed?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.