diffplug / diffplug/spotless

Investigate Javenode and/or JNpm

Ouverte
#934 0 commentaires 4 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Java
Étoiles
5.7k
Forks
561
Merge moyen
1 j 14 h
PR mergées (30 j)
43

Description

Right now, we integrate with node.js formatting tasks by finding a Node.js and NPM installation on the host machine

- using npm to install the required formatter, usually prettier, which is slow (#766)
- [JNPM](https://github.com/OrienteerBAP/JNPM) might be able to do this better
- starting a localhost server in java, and another in node.js, and passing strings back and forth between them
- [Javenode](https://github.com/caoccao/Javenode) would allow us to do this in-process.
- Upside: fancy [module intercepting](https://github.com/diffplug/spotless/issues/556#issuecomment-919613345) which could cooperate with something like JNPM
- Upside: passing strings within-process would be faster, but this is minor
- Upside: don't need to futz with Spotless finding a node.js installation
- Downside: can't futz with Spotless using a specific node.js installation which might match other non-java tooling

I don't plan to work on any of this, but I think #766 is a big problem. If anyone wants to experiment with the above, they are very welcome to! An important part for getting a PR merged will be a real-world project, where you can say "it was X seconds before, and it's Y seconds now". I don't want to swap things just to swap them.

If there's an easy way to keep the old mechanism and the new mechanism at the same time, that might be nice, but it's fine to remove the old mechanism as part of the PR too. Maybe the new mechanism dominates the old, and if it doesn't we can figure out how to get them to coexist after the fact.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Examinez #766 ainsi que les projets liés Javenode et JNPM afin de comprendre le workflow actuel du formateur Node.js et les alternatives possibles. Une étude complète doit inclure une comparaison en conditions réelles des mécanismes existant et proposé, présenter les temps de traitement avant et après, et expliquer si les anciennes et nouvelles approches doivent coexister.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
java, node.js
Domaine
build-system, tooling
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.