diffplug / diffplug/spotless

SBT support

Offen
#688 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
enhancement
Vorherrschende Sprache
Java
Sterne
5.6k
Forks
559
Ø Merge
1 T. 13 Std.
Gemergte PRs (30 T.)
34

Beschreibung

@moznion has made a spotless plugin for the sbt buildsystem. I bumped into it the other day, and I began a conversation with the author about the option of upstreaming it https://github.com/moznion/sbt-spotless/issues/22

We should definitely let our users know that it exists by linking to it in the root README. I think it would also be good to upstream it into the spotless repo. The advantage of that is that when we add features / fix bugs in various steps, it would be easier for sbt users to know which versions to use. For spotless users that don't use `sbt`, it helps to have more eyes on the various steps - you never know who might fix a bug or bring a feature.

The downside of having more build steps is that our build gets bigger and slower. Right now, we have the ability to exclude the maven plugin, we could always change it to where all the plugins are excluded, and you have to manually set `SPOTLESS_INCLUDE_GRADLE` or `SPOTLESS_INCLUDE_SBT`, so that developers working on the build system they care about don't get bogged down by the larger scope.

https://github.com/diffplug/spotless/blob/74d964d22636e58e897ff298c6df996e3fac2b69/settings.gradle#L47-L49

The main challenge to upstreaming @moznion's work is just

- a PR with a folder `plugin-sbt`
- add the folder to `settings.gradle`
- get it building via gradle, so that our publishing works https://docs.gradle.org/current/userguide/scala_plugin.html

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.