diffplug / diffplug/spotless

Gradle does not detect java sources for `java-gradle-plugin`

Aperta
#437 0 commenti 1 reazione 1 assegnatario Rivendicata da @nedtwigg Vedi su GitHub
bug
Lingua principale
Java
Stelle
5.6k
Fork
559
Merge medio
1g 13h
PR unite (30g)
34

Descrizione

With gradle `4.1` and spotless `3.6.0`, the following worked. With gradle `5.6` and spotless `3.24.1`, it silently fails to format sources.

```gradle
apply plugin: 'java-gradle-plugin'
spotless {
java { ... }
}
```

This is similar to #111 (spotless fails to detect android sources). Just like #111, the workaround is to list the target explicitly: `target 'src/main/java/**/*.java', 'src/test/java/**/*.java'`.

Silently not formatting is a bummer. Would perhaps be good for Spotless to report a warning if a format has been described, but the target turned out to be empty.

Project which reproduces this issue:

- works before this commit, broken after it: https://github.com/diffplug/image-grinder/pull/2/commits/3e73517746e1a1bf899a8b593c21cf71c2a72c8e
- workaround: https://github.com/diffplug/image-grinder/pull/2/commits/8b69781c6ee90a59c6546eaa99ba5065ace38aff

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.