diffplug / diffplug/spotless

git setting of line endings are not fetched from gitconfig file in git home folder

Offen
#2,342 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
bug-unconfirmed
Vorherrschende Sprache
Java
Sterne
5.6k
Forks
559
Ø Merge
1 T. 14 Std.
Gemergte PRs (30 T.)
43

Beschreibung

- [x] summary of problem
My C:\Program Files\Git\etc\gitconfig file has a [core] autocrlf = input setting but this parameter is not defined in $HOME/.gitconfig.
kotlin, kotlinGradle, groovy, shell, json, yaml, format("markdown"), format("text") has a problem with LF line ending and fixes to CRLF. Java is not effected.
If [core] autocrlf = input set in $HOME/.gitconfig, spotless works well.
- [x] Gradle or Maven version
Gradle 8.11
- [x] spotless version
6.25
- [x] operating system and version
Win 11
- [x] copy-paste your full Spotless configuration block(s), and a link to a public git repo that reproduces the problem if possible
`spotless {
java {
target("**/*.java")
targetExclude(defaultExcludes)
googleJavaFormat(libs["google-java-format"].version)
.reflowLongStrings()
.formatJavadoc(true)
targetExclude(defaultExcludes)
}
kotlin {
target("**/*.kt")
targetExclude(defaultExcludes)
ktfmt(libs["ktfmt"].version).googleStyle()
}
kotlinGradle {
ktfmt(libs["ktfmt"].version).googleStyle()
targetExclude(defaultExcludes)
}
groovy {
target("**/*.groovy", "Jenkinsfile", "**/Jenkinsfile.*")
targetExclude(defaultExcludes)
trimTrailingWhitespace()
endWithNewline()
}
shell {
target("**/*.sh", "src/main/sh/**/*")
targetExclude(defaultExcludes)
localPrettier(libs["prettier"], libs["prettier-sh"])
.config(
mapOf(
"plugins" to listOf("prettier-plugin-sh"),
"parser" to "sh",
*prettierDefaults
)
)
trimTrailingWhitespace()
endWithNewline()
}
json {
target("**/*.json", "**/*.json5")
targetExclude(defaultExcludes)
localPrettier(libs["prettier"])
.config(mapOf(*prettierDefaults))
}
yaml {
target("**/*.yaml", "**/*.yml")
targetExclude(defaultExcludes)
localPrettier(libs["prettier"])
.config(mapOf(*prettierDefaults))
}
format("markdown") {
target("**/*.md")
targetExclude(defaultExcludes)
localPrettier(libs["prettier"])
.config(mapOf(*prettierDefaults))
}
format("text") {
target(
"**/.gitattributes",
"**/.gitignore",
"**/.npmrc",
"**/.sdkmanrc",
"**/*.properties",
"Dockerfile",
"**/*.txt",
"**/*.config"
)
targetExclude(defaultExcludes)
trimTrailingWhitespace()
endWithNewline()
indentWithSpaces(2)
}
}`

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Reproduce the issue on Windows 11 with Gradle 8.11 and Spotless 6.25 using the configuration shown, comparing C:\Program Files\Git\etc\gitconfig with $HOME/.gitconfig. Check the Kotlin, Groovy, shell, JSON, YAML, Markdown, and text format targets; done means core.autocrlf from the Git home configuration is honored and files retain the expected LF endings.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
groovy, java, json, kotlin, markdown, shell, yaml
Bereich
build-system
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.