diffplug / diffplug/spotless

Use newer JDT libraries to avoid annoying "error" warnings

Open
#1,778 1 comment 5 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
5.6k
Forks
559
Avg merge
1d 13h
Merged PRs (30d)
34

Description

## Situation
Our build had some errors outputs from Gradle at at https://github.com/mercedes-benz/sechub/issues/1658.
The reason was the usage of spotless which relies on JDT parts for automated eclipse formatting, which have a bug inside: https://github.com/eclipse-platform/eclipse.platform/issues/180

Following output was shown multiple times:
```
Errors occurred while build effective model from /home/runner/.gradle/caches/modules-2/files-2.1/org.eclipse.platform/org.eclipse.core.expressions/3.8.200/eb159f34083b0135459745f934a6ad5eb61b61c/org.eclipse.core.expressions-3.8.200.pom:
'modelVersion' must be one of [4.0.0] but is '4.0'. in org.eclipse.platform:org.eclipse.core.expressions:3.8.200
```
It's not really breaking the build but just an anoying list of "errors", which are none.

- [x] summary of problem
- Spotless uses older eclipse core libraries which had this bug inside
- The bug is fixed in newer eclipse library versions version, see
https://github.com/eclipse-platform/eclipse.platform/issues/180#issuecomment-1636749660
- [x] gradle version: 7.x, 8.x (does not really matter)
- [x] spotless version: 6.2.0 and earlier
- [x] Any OS

## Proposal
- Solution should be to use eclipse core libraries version >= 3.9.0
(please look at https://github.com/eclipse-platform/eclipse.platform/issues/180#issuecomment-1636749660 for details)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.