diffplug / diffplug/selfie

Remove requirement to not have "/" in test names? (Junit 5)

Abierto
#514 1 comentario 0 reacciones 0 asignados Ver en GitHub
enhancement jvm
Lenguaje dominante
Kotlin
Estrellas
101
Forks
18
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Fantastic tool, thank you! I only hit a little snag: in my project I already have many Kotest/Junit5 units named after HTTP endpoints such as `GET /example`, and I'm hitting this error:

```
Caused by: java.lang.IllegalStateException: Test name cannot contain '/', was ...
at com.diffplug.selfie.junit5.SnapshotFileProgress.startTest(SnapshotSystemJUnit5.kt:188)
```

This happens for every test even though they do not invoke Selfie for snapshots. Could this requirement be loosened somehow? For example:

* Escape the resulting name of snapshot files to remove the slash
* Do not run this check in tests that do not make use of Selfie

Thank you.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start at SnapshotSystemJUnit5.kt:188, where SnapshotFileProgress.startTest rejects test names containing '/'. Reproduce the issue with a JUnit 5 test named like `GET /example`, then determine whether the check should be relaxed or limited to tests using Selfie. Done means such test names no longer fail unnecessarily while snapshot file names remain valid.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
kotlin
Área
testing
Tipo de issue
Nueva funcionalidad
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.