diffplug / diffplug/gitcasso

modify or replace OverType

Ouverte
#99 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
HTML
Étoiles
58
Forks
0
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

We are currently using the [OverType](https://overtype.dev/) library for syntax highlighting. Our biggest problem with it is that we are using it to *modify* text areas, but it's really built to *create* them. We're working against its nature in lots of places.

For example, right now we don't / can't enhance text areas by default, we only enhance very specific ones that we have targeted. This is because when we enhance a text area, we clobber its styling, and we have to manually put it all back how it was:

https://github.com/diffplug/gitcasso/blob/57fe5689b094d7ea9475e613fd033f4987c37fb0/src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx#L71-L75

Also, whatever method it uses to listen for changes doesn't always work. For example, when images get dragged on to the GitHub textarea, the preview unsyncs briefly, but this can fix it:

https://github.com/diffplug/gitcasso/blob/57fe5689b094d7ea9475e613fd033f4987c37fb0/src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx#L77-L82

Changes we have made:

- several removals of functionality related to
- added support for GitHub hashlinks e.g. `#34` https://github.com/diffplug/overtype/commit/f5149dce2125e1f3749961eaa4f12b75af648946

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by reading src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx at the linked styling and change-listener sections, then review the current OverType integration and the listed fork changes. Done means modifying or replacing OverType so enhanced text areas retain their styling, stay synchronized when images are dragged in, and preserve GitHub hashlink support.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
github, react, typescript
Domaine
frontend
Type d'issue
Refactorisation
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
À l'abandon
Clarté
À clarifier
Accessibilité débutants
25/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.