developit / developit/workerize-loader

[path] replacer token passed to workerize-loader has stopped working in Webpack 5

Abierto
#130 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
2.3k
Forks
85
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Used to be the case with Webpack 4 that we could pass `[path][name].[contenthash]` as the name template for workerize-loader to use; and we'd get workers output into a folder structure mirroring their original source location.

This was nice for debugging purposes to easily identify workers, because the entry point file for esp. larger workers is usually some kind of `index.js` file. `[path]` means you don't need to inspect every separate worker named `index.[hash].worker.js` - and it prevented name collisions when you would generate names in development builds without hash fingerprints in them.

As of Webpack 5, that functionality appears to be broken. It resolves `[name]` and `[contenthash]` just fine, but doesn't know how to deal with `[path]`.

I'm using a plugin to dynamically inject options into loaders to configure bare loader URLs such as
```js
import worker from "workerize-loader!./path-to/worker"
```

centrally, and luckily I was able to extend the logic there to use the current compilation context and module context to compute a relative path, but yeah... _this_ is not very ergonomic, easily understood or maintainable:

```js
new InjectOptionsPlugin({
loaders : {
"workerize-loader" : ( module, compilation ) => {
const context = path
.relative( compilation.options.context, module.context );
.replace( /\\/g, "/" );

return {
name : dev ? `${context}[name]` : "${context}[name].[contenthash]`
};
}
}
})
```

compared to what it _used_ to be:

```js
new InjectOptionsPlugin({
loaders : {
"workerize-loader" : {
name : dev ? "[path][name]" : "[path][name].[contenthash]"
}
}
})
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Reproduce the issue with workerize-loader under Webpack 5 using the bare loader URL and the `[path][name].[contenthash]` template described here. Trace how the loader handles its name option and compare `[path]` with the working `[name]` and `[contenthash]` tokens; done means worker output preserves source-relative paths without requiring external option injection.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript, webpack
Área
build-system, tooling
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.