developit / developit/web-worker
`1.5.0` regression: workers treated as ESM by default
- Linguagem predominante
- JavaScript
- Estrelas
- 1.2k
- Forks
- 57
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
Hi,
Glad to stumbled on this neat project and looking forward to using it to write more consistent browser-node code.
I'm trying to get duckdb-wasm working in node, I found a [`bare-node`](https://github.com/duckdb/duckdb-wasm/blob/main/examples/bare-node/index.cjs) example in their repo.
It fails when I run it, with error:
`ReferenceError: module is not defined`
It uses web-worker, and it seems like the worker code (clearly CJS and with file extension `cjs`) gets detected like an ESM module.
Downgrading web-worker from `1.5.0` to `1.4.1` fixes the issue. I tried a few other things like passing type: commonjs, type: classic - none worked.
Suggests a regression in 1.5.0 release (edit: unless changing the default behavior in 1.5.0 is intentional)
Thanks
Declan
Guia de contribuição
Direção de pesquisa
Start by running the duckdb-wasm bare-node example at examples/bare-node/index.cjs with web-worker 1.5.0, then compare it with 1.4.1. Trace how the worker script is loaded and how its module type is selected; done means the CJS worker runs under 1.5.0 without the `module is not defined` error while preserving the documented worker behavior.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- javascript, node.js
- Domínio
- backend
- Tipo de issue
- Bug
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Status de atividade
- Pouca atividade
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 52/100